New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #12704 by adding a test (tuple codegen error) #13592

Merged

Araq merged 2 commits into nim-lang:devel from timotheecour:pr_close_12704_codegen_tuple

Mar 6, 2020

Member

timotheecour commented Mar 5, 2020 •

edited

Loading

close tuple codegen error #12704 by adding a test
git bisect shows this was fixed (by "accident") in fixes crash on type.name[0] [backport] #12809 , thanks @cooldome
I wonder if these also need fixing similarly to fixes crash on type.name[0] [backport] #12809:

compiler/lambdalifting.nim:136:31:  if intType.isNil: intType = newType(tyInt, iter)
compiler/semmagic.nim:166:18:    result.typ = newType(tyInt, context)

failure unrelated, caused by [CI] tests/async/tioselectors.nim flaky test for freebsd + OSX CI #13166

timotheecour added 2 commits

March 5, 2020 14:41


          close nim-lang#12704 by adding a test

eed4acf


          move test to tests/metatype/ttypedesc2.nim

f64c7ec

Araq merged commit b80d293 into nim-lang:devel

timotheecour deleted the pr_close_12704_codegen_tuple branch

March 6, 2020 08:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet