Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix newDomParser #13981

Merged
merged 1 commit into from
Apr 16, 2020
Merged

fix newDomParser #13981

merged 1 commit into from
Apr 16, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 14, 2020

/cc @juancarlospaco my comment from #13920 (comment) was not addressed

this doesn't work, you must've pasted from a webpage and introduced an invisible symbol (see cat -e). you should make sure examples work
also, you should remove outer parens

before PR, newDomParser will not work, giving Uncaught SyntaxError: Unexpected identifier in a browser
this won't show up in github UI, you can only see the difference locally using cat -e

CI failure unrelated and would be fixed by #13984

@Varriount
Copy link
Contributor

Is there a way to test this?

@timotheecour
Copy link
Member Author

in my unreleased patch, i can do smthg like nim js -d:nimbrowser main and it opens in browser a template html that links against generated js; but you can do the same manually

@Araq Araq merged commit 6914de0 into nim-lang:devel Apr 16, 2020
@timotheecour timotheecour deleted the pr_fix_dom_parser branch April 16, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants