Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[superseded] badge for freebsd,openbsd now reflect latest commit to devel, not latest PR; add badge for new Packages CI #14155

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Apr 29, 2020

@Clyybber
Copy link
Contributor

Whats the purpose of these badges actually?
IMO they only serve to detract potential Nim users because of unrelated CI failures.

@timotheecour
Copy link
Member Author

timotheecour commented Apr 29, 2020

For new visitors, it actually shows a project is maintained and tested rigorously, on many platforms.
For contributors, it surfaces errors so they get fixed fast. "out of sight, out of mind"

unrelated CI failures

actually badges help distinguishing "unrelated CI failures" in your PR vs "caused by your PR", because they tell show you the state as of last commit.

@timotheecour timotheecour force-pushed the pr_fix_badge_builds_sr_ht_openbsd_freebsd branch from dbfdfe4 to a0d9d5b Compare April 29, 2020 21:46
@timotheecour timotheecour force-pushed the pr_fix_badge_builds_sr_ht_openbsd_freebsd branch from a0d9d5b to fc9476c Compare April 30, 2020 22:40
@Clyybber
Copy link
Contributor

Clyybber commented May 1, 2020

We have decided to only leave the Azure CI badge there, so I'm closing this.

@Clyybber Clyybber closed this May 1, 2020
@timotheecour
Copy link
Member Author

timotheecour commented May 1, 2020

@Clyybber What's the rationale for removing them (or please link to discussion where this was discussed), and can we have those badges in some other markdown file in nim repo if not on the top-level readme; they are useful.

Azure badges only reflect part of what's under CI; since we're testing other pipelines, these should be shown too, it's just good testing hygiene / standard practice.

@Clyybber
Copy link
Contributor

Clyybber commented May 1, 2020

The rationale was that they look ugly, clutter the readme and don't provide anything to people checking out the readme. (And they detract potential users when they are red)
Also neither rust or go have them in their readme either (I guess for the same reasons)

@timotheecour timotheecour deleted the pr_fix_badge_builds_sr_ht_openbsd_freebsd branch May 8, 2020 02:01
@timotheecour timotheecour changed the title badge for freebsd,openbsd now reflect latest commit to devel, not latest PR; add badge for new Packages CI [superseded] badge for freebsd,openbsd now reflect latest commit to devel, not latest PR; add badge for new Packages CI May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants