Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --backend:cpp|js work for :test: code-blocks as well #14300

Closed
wants to merge 1 commit into from

Conversation

kaushalmodi
Copy link
Contributor

@kaushalmodi kaushalmodi commented May 11, 2020

@Araq
Copy link
Member

Araq commented May 11, 2020

Well if I write nim c in the tests, I expect nim c. How about supporting nim $backend instead?

@Araq Araq closed this May 11, 2020
@Araq Araq reopened this May 11, 2020
@kaushalmodi
Copy link
Contributor Author

@Araq May be I wasn't clear.. it is hardcoded to nim c here:

params.testCmd = "nim c -r $1"

@kaushalmodi
Copy link
Contributor Author

If you intend to use the c backend for those tests, this PR won't change anything.

@Araq
Copy link
Member

Araq commented May 11, 2020

It's hardcoded, yes, but I think if I write it down myself your code will be applied anyhow.

@kaushalmodi
Copy link
Contributor Author

I think if I write it down myself your code will be applied anyhow

Hmm, yes. But are there real use cases where in the same .nim file, you have a mix of nim c .. and nim cpp .. :test: code blocks?

@kaushalmodi
Copy link
Contributor Author

I'll close this PR. I will update my std_vector wrapper with:

.. code-block:: nim
    :test: "nim cpp -r $1"

kaushalmodi added a commit to kaushalmodi/std_vector that referenced this pull request May 11, 2020
kaushalmodi added a commit to kaushalmodi/std_vector that referenced this pull request May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying/forcing the compilation backend in Nim for nim doc
2 participants