Add support for mktemps #14347
Merged
Add support for mktemps #14347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2020
lib/posix/posix.nim
Outdated
| proc mkstemps*(tmpl: cstring, suffixlen: int): cint {.importc, header: "<stdlib.h>", sideEffect.} | ||
| ## Creates a unique temporary file. | ||
| ## | ||
| ## **Warning**: The `tmpl` argument is written to by `mkstemp` and thus |
|
@maxgrenderjones any reason this is in draft? IMO it's good to merge (and my nits can be addressed after merge) or, even better, you can update those nits |
More because I didn't know what I was doing and I hadn't tested a version of nim built with it. I have however tested the function standalone in my code (on OSX) and it works as desired. Let me know if you need to squash the changes or whether you can do that in the merge (wasn't sure whether it would mess up reviewing). (Context for all this: I know |
timotheecour
approved these changes
May 23, 2020
|
Thanks, its good as is, github ui can squas and merge. |
EchoPouet
pushed a commit
to EchoPouet/Nim
that referenced
this pull request
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to python's
tempfileadd support for a suffix in mkstemp.