Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:getCurrentException() and getCurrentExceptionMsg() are not available for imported exceptions #14392

Merged
merged 2 commits into from
May 18, 2020

Conversation

cooldome
Copy link
Member

Clarify that getCurrentException() and getCurrentExceptionMsg() are not available for imported cpp exceptions

@timotheecour
Copy link
Member

nit: are not available for imported exceptions is a bit vague; calling getCurrentException() is (currently) possible and would return nil

@timotheecour timotheecour changed the title improve imported exceptions doc docs:getCurrentException() and getCurrentExceptionMsg() are not available for imported exceptions May 18, 2020
@timotheecour timotheecour merged commit 810039e into devel May 18, 2020
@timotheecour timotheecour deleted the imported_exceptions_doc_improvement branch May 18, 2020 15:15
@dom96
Copy link
Contributor

dom96 commented Jun 13, 2020

Yeah, I agree that this is vague. Most won't know what imported exceptions are. We should at least mention CPP in this. d3b25a2

EchoPouet pushed a commit to EchoPouet/Nim that referenced this pull request Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants