Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler/commands: make gitHash settable at compile-time. #14654

Merged
merged 1 commit into from
Jun 14, 2020

Conversation

alaviss
Copy link
Collaborator

@alaviss alaviss commented Jun 13, 2020

This is useful for building nightlies, since we will be building from a
generated source archive and git metadata is lost there.

This is useful for building nightlies, since we will be building from a
generated source archive and git metadata is lost there.
@alaviss
Copy link
Collaborator Author

alaviss commented Jun 13, 2020

CI failure unrelated.

@timotheecour
Copy link
Member

This is useful for building nightlies, since we will be building from a generated source archive and git metadata is lost there.

seems like the wrong way to do this; instead the function that generates the source archive should dump this information (as json, of course) so nothing is lost.

@alaviss
Copy link
Collaborator Author

alaviss commented Jun 13, 2020

seems like the wrong way to do this; instead the function that generates the source archive should dump this information (as json, of course) so nothing is lost.

How are you gonna feed it back to the compiler afterwards? :)

@Araq Araq merged commit d749c8c into nim-lang:devel Jun 14, 2020
@Araq
Copy link
Member

Araq commented Jun 14, 2020

Merging it because nightlies need to be fixed ASAP.

@timotheecour
Copy link
Member

timotheecour commented Jun 14, 2020

fine, can be changed later

How are you gonna feed it back to the compiler afterwards? :)

@alaviss what I had in mind was:

by just trying both git log -n 1 --format=%H and readFile("nimdump.json") ?
(or the const version of those, although const really isn't needed in compiler/commands)

@alaviss alaviss deleted the set-hash branch June 14, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants