fix several newline problems #15028
Merged
fix several newline problems #15028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason checks are with |
Varriount
reviewed
Jul 21, 2020
| @@ -146,7 +146,11 @@ proc send*(ftp: AsyncFtpClient, m: string): Future[TaintedString] {.async.} = | |||
| ## Send a message to the server, and wait for a primary reply. | |||
| ## ``\c\L`` is added for you. | |||
| ## | |||
| ## You need to make sure that the message ``m`` doesn't contain any newline | |||
| ## characters. Failing to do so will raise ``AssertionDefect``. | |||
There was a problem hiding this comment.
In non-release mode, right? Aren't assertions turned off for release mode?
There was a problem hiding this comment.
@Varriount doAssert assertions are always enabled
Araq
reviewed
Jul 21, 2020
| @@ -245,7 +245,8 @@ proc contentLength*(response: Response | AsyncResponse): int = | |||
| ## | |||
| ## A ``ValueError`` exception will be raised if the value is not an integer. | |||
| var contentLengthHeader = response.headers.getOrDefault("Content-Length") | |||
| return contentLengthHeader.parseInt() | |||
| result = contentLengthHeader.parseInt() | |||
There was a problem hiding this comment.
Use parseSaturatedNatural because that cannot raise an overflow exception.
There was a problem hiding this comment.
Yes, but that changes the documented behaviour:
A
ValueErrorexception will be raised if the value is not an integer.
import parseutils, strutils
var a = "123.45"
var b: int
discard parseSaturatedNatural(a, b)
echo b # ==> 123
var c = parseInt(a)
echo c # ==> ValueError
narimiran
added a commit
that referenced
this pull request
Jul 22, 2020
* prevent newlines where they shouldn't be * 'contentLength' shouldn't be negative (cherry picked from commit 5fafa2f)
narimiran
added a commit
that referenced
this pull request
Jul 22, 2020
* prevent newlines where they shouldn't be * 'contentLength' shouldn't be negative (cherry picked from commit 5fafa2f)
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* prevent newlines where they shouldn't be * 'contentLength' shouldn't be negative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.