Add test-cases for #12576 and #12523 #15085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 27, 2020 03:09
ghost
changed the title
ghost
commented
Jul 27, 2020
|
|
||
| # bug 12523 | ||
| template myCustomPragma {.pragma.} |
There was a problem hiding this comment.
I changed the "customPragma" pragma name because it conflicts with the imported "custompragma" module symbol, not sure if that's a bug or not
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* Add a test-case for nim-lang#12576 * Add a test-case for nim-lang#12523
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed a few comments for the issues as specified in http://nim-lang.github.io/Nim/contributing.html#writing-tests-stdlib. Maybe we should do it for the whole test suite? :) I can start with some categories
Closes #12576
Closes #12523