asyncnet: don't try to close the socket again [backport] #15174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaviss
changed the title
dom96
requested changes
Aug 11, 2020
lib/pure/asyncnet.nim
Outdated
| elif res != 1: | ||
| raiseSSLError() | ||
| socket.closed = true # TODO: Add extra debugging checks for this. | ||
| if not socket.closed: |
There was a problem hiding this comment.
Prefer:
if socket.closed: return
Style rather than wrapping everything in more and more nested ifs.
The closed flag isn't a good design by any means, but let's have this working first before I get rid of the flag and potentially create a non-backportable commit.
alaviss
force-pushed
the
asyncnet-double-close-fix
branch
from
dcf8946
to
fecaa03
Compare
|
|
it always calls |
|
Nah, |
|
That sounds dangerous, but alright, in any case I would still match the semantics in |
|
Currently I'm not doing that because I'm not invalidating the socket. I can certainly do so, but IMO it's better to do that with the follow up refactoring to get rid of the |
narimiran
pushed a commit
that referenced
this pull request
Sep 11, 2020
The closed flag isn't a good design by any means, but let's have this working first before I get rid of the flag and potentially create a non-backportable commit. (cherry picked from commit 957bf15)
narimiran
pushed a commit
that referenced
this pull request
Sep 11, 2020
The closed flag isn't a good design by any means, but let's have this working first before I get rid of the flag and potentially create a non-backportable commit. (cherry picked from commit 957bf15)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closed flag here doesn't seem to be a a good design to me, but until
I can understand why it was needed it seems unwise to just replace it
with the invalidation of the socket.
Fixes #9867 (comment)
/cc @dom96 as this
closedflag was added by him. This flag appear to have survived the refactoring in 1661062, where its sisternetmodule use the different approach of invalidating theSocketinstead of a flag.