Introduce explicit copy #15330
Merged
Introduce explicit copy #15330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should it be |
|
added inline |
|
Maybe this should warn when we do an eplicit but unneccessary copy? I think a better idea is to not emit the warnings unless requested, as this solution could lead to library authors not using sink so that the API is nicer. |
Araq
added a commit
that referenced
this pull request
Sep 16, 2020
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
This reverts commit a3e9cc5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way to manage the performance warning. Also makes performance predictable.