Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parseFloatThousandSep #15421

Closed
wants to merge 86 commits into from
Closed

Add parseFloatThousandSep #15421

wants to merge 86 commits into from

Commits on Sep 28, 2020

  1. Add parseFloatThousandSep

    @juancarlospaco
    juancarlospaco committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    1ecf6ed View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    817df69 View commit details
    Browse the repository at this point in the history

  2. https://github.com/nim-lang/Nim/pull/15421#issuecomment-700791178

    @juancarlospaco
    juancarlospaco committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    0b79ec4 View commit details
    Browse the repository at this point in the history

  3. https://github.com/nim-lang/Nim/pull/15421#issuecomment-700791178

    @juancarlospaco
    juancarlospaco committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    53c3e18 View commit details
    Browse the repository at this point in the history

  4. https://github.com/nim-lang/Nim/pull/15421#issuecomment-700791178

    @juancarlospaco
    juancarlospaco committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    b3ada57 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    ec57030 View commit details
    Browse the repository at this point in the history

  2. feedback

    @juancarlospaco
    juancarlospaco committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    d63112c View commit details
    Browse the repository at this point in the history

  3. feedbacks

    @juancarlospaco
    juancarlospaco committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    590702a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    2163a46 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    5b2b630 View commit details
    Browse the repository at this point in the history

  2. https://github.com/nim-lang/Nim/pull/15421#discussion_r505507037

    @juancarlospaco
    juancarlospaco committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    af6821a View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    d1c768e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'float-thousands-separators' of https://github.com/juanc… 

    …arlospaco/Nim into float-thousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    237aeef View commit details
    Browse the repository at this point in the history

  3. https://github.com/nim-lang/Nim/pull/15421#discussion_r522453389

    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    af078ea View commit details
    Browse the repository at this point in the history

  4. https://github.com/nim-lang/Nim/pull/15421#discussion_r522453304

    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    923663d View commit details
    Browse the repository at this point in the history

  5. Remove unlikely

    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    32d68e9 View commit details
    Browse the repository at this point in the history

  6. Fix Changelog conflicts

    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    d2bb63f View commit details
    Browse the repository at this point in the history

  7. https://github.com/nim-lang/Nim/pull/15421#discussion_r522454607

    @juancarlospaco
    juancarlospaco committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    6547469 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2020

  1. Delete half runnableExamples

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    bf88002 View commit details
    Browse the repository at this point in the history

  2. Move half runnableExamples to testament

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    2d2f558 View commit details
    Browse the repository at this point in the history

  3. clean out

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a02f7e1 View commit details
    Browse the repository at this point in the history

  4. https://github.com/nim-lang/Nim/pull/15421#discussion_r522517532

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    3901c56 View commit details
    Browse the repository at this point in the history

  5. Add raise test

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    4c58bdd View commit details
    Browse the repository at this point in the history

  6. See also to func not to module

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    e19a15c View commit details
    Browse the repository at this point in the history

  7. See also to func not to module

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    b8310c3 View commit details
    Browse the repository at this point in the history

  8. Improve a test

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    48828f5 View commit details
    Browse the repository at this point in the history

  9. raise proc

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a98907b View commit details
    Browse the repository at this point in the history

  10. improve the improvements

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    e1e43fc View commit details
    Browse the repository at this point in the history

  11. improve the improvements

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    ce8c591 View commit details
    Browse the repository at this point in the history

  12. improve the improvements

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    842532d View commit details
    Browse the repository at this point in the history

  13. the noinline thingy

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    0d2ac4d View commit details
    Browse the repository at this point in the history

  14. char repr

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c754556 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c3f56ed View commit details
    Browse the repository at this point in the history

  16. https://github.com/nim-lang/Nim/pull/15421#discussion_r522586680

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c151058 View commit details
    Browse the repository at this point in the history

  17. https://github.com/nim-lang/Nim/pull/15421#discussion_r522587122

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a18df8a View commit details
    Browse the repository at this point in the history

  18. https://github.com/nim-lang/Nim/pull/15421#discussion_r522587122

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    64a306f View commit details
    Browse the repository at this point in the history

  19. https://github.com/nim-lang/Nim/pull/15421#discussion_r522587122

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    f5314a1 View commit details
    Browse the repository at this point in the history

  20. https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    fce794c View commit details
    Browse the repository at this point in the history

  21. https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    765b6da View commit details
    Browse the repository at this point in the history

  22. https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    7c6c941 View commit details
    Browse the repository at this point in the history

  23. https://github.com/nim-lang/Nim/pull/15421#discussion_r522636227

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    d37375e View commit details
    Browse the repository at this point in the history

  24. Add 1 assert to test

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    f8886ba View commit details
    Browse the repository at this point in the history

  25. Add 1 assert to test

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    744355f View commit details
    Browse the repository at this point in the history

  26. https://github.com/nim-lang/Nim/pull/15421#discussion_r522671941

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    a14b96d View commit details
    Browse the repository at this point in the history

  27. Add a comment

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    4ec5d07 View commit details
    Browse the repository at this point in the history

  28. Remove confusing doc line

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    7411586 View commit details
    Browse the repository at this point in the history

  29. https://github.com/nim-lang/Nim/pull/15421#discussion_r522678760

    @juancarlospaco
    juancarlospaco committed Nov 13, 2020
    Configuration menu
    Copy the full SHA
    c8f210d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    2ab6f83 View commit details
    Browse the repository at this point in the history

  2. https://github.com/nim-lang/Nim/pull/15421#discussion_r522841456

    @juancarlospaco
    juancarlospaco committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    38b26f1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    6a38d57 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    eca6572 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    82a49c3 View commit details
    Browse the repository at this point in the history

  3. refactor and more tests

    @juancarlospaco
    juancarlospaco committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    5e55e92 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    412c652 View commit details
    Browse the repository at this point in the history

  5. Resync devel

    @juancarlospaco
    juancarlospaco committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    2a95434 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Clean

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    e181640 View commit details
    Browse the repository at this point in the history

  2. Clean

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    b272708 View commit details
    Browse the repository at this point in the history

  3. Clean

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    cd9e3b6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    41876f2 View commit details
    Browse the repository at this point in the history

  5. Simplify

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    bbfe1b8 View commit details
    Browse the repository at this point in the history

  6. Simplify

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    bf6cf49 View commit details
    Browse the repository at this point in the history

  7. Allow {pfLeadingDot,pfTrailingDot}

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    d11359a View commit details
    Browse the repository at this point in the history

  8. Allow {pfLeadingDot,pfTrailingDot}

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    3766512 View commit details
    Browse the repository at this point in the history

  9. https://github.com/nim-lang/Nim/pull/15421#discussion_r526731954

    @juancarlospaco
    juancarlospaco committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    4bad51a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    18fd3c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'float-thousands-separators' of https://github.com/juanc… 

    …arlospaco/Nim into float-thousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    4619329 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    32ae2e5 View commit details
    Browse the repository at this point in the history

  2. https://github.com/nim-lang/Nim/pull/15421/files#r526547810

    @juancarlospaco
    juancarlospaco committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    68a8228 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. peer review feedbacks

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    4f3b1ee View commit details
    Browse the repository at this point in the history

  2. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    6dd41c9 View commit details
    Browse the repository at this point in the history

  3. 1.0e9

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    e90786f View commit details
    Browse the repository at this point in the history

  4. 1.0e9

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    87ca6ae View commit details
    Browse the repository at this point in the history

  5. 1.0e9

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    bdfc4f5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    7ef7138 View commit details
    Browse the repository at this point in the history

  7. NaN

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    2114087 View commit details
    Browse the repository at this point in the history

  8. ReSync devel

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    5558fac View commit details
    Browse the repository at this point in the history

  9. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    cc24825 View commit details
    Browse the repository at this point in the history

  10. is always scientific

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    15d832b View commit details
    Browse the repository at this point in the history

  11. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    4769a90 View commit details
    Browse the repository at this point in the history

  12. https://github.com/nim-lang/Nim/pull/15421#discussion_r529793041

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    12854c1 View commit details
    Browse the repository at this point in the history

  13. Clean out

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    d747b18 View commit details
    Browse the repository at this point in the history

  14. moar test

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    093b826 View commit details
    Browse the repository at this point in the history

  15. sep and dot must not be '+', 'e', 'i', 'n', 'f', 'a'

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    c61993e View commit details
    Browse the repository at this point in the history

  16. sep and dot must not be '+', 'e', 'i', 'n', 'f', 'a'

    @juancarlospaco
    juancarlospaco committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    8040f52 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2020

  1. Merge branch 'devel' of https://github.com/nim-lang/Nim into float-th… 

    …ousands-separators
    @juancarlospaco
    juancarlospaco committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    92b2ae6 View commit details
    Browse the repository at this point in the history

  2. We need doAssert that takes varargs for tests

    @juancarlospaco
    juancarlospaco committed Nov 29, 2020
    Configuration menu
    Copy the full SHA
    fcc5c35 View commit details
    Browse the repository at this point in the history