Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a getter for all defined Sections in parsecfg #15450

Merged
merged 5 commits into from
Mar 28, 2021
Merged

Add a getter for all defined Sections in parsecfg #15450

merged 5 commits into from
Mar 28, 2021

Conversation

ardek66
Copy link
Contributor

@ardek66 ardek66 commented Oct 1, 2020 •
edited
Loading

Fixes: #12904

@ghost
Copy link

ghost commented Oct 1, 2020

IMO it's better to make that as an iterator.

ghost
ghost reviewed Oct 1, 2020
View reviewed changes
lib/pure/parsecfg.nim Outdated Show resolved Hide resolved
@ardek66
Copy link
Contributor Author

ardek66 commented Oct 1, 2020 •
edited
Loading

Fair, I assumed the issue was about getting a sequence of sections

@juancarlospaco
Copy link
Collaborator

You can get a seq from iterator using toSeq.
:)

@Araq
Copy link
Member

Araq commented Oct 1, 2020

Needs a .since annotation.

@ardek66
Copy link
Contributor Author

ardek66 commented Oct 1, 2020 •
edited
Loading

Forgot to remove unnecessary ident spaces...

@ringabout
Copy link
Member

Needs changelog

Araq
Araq reviewed Oct 28, 2020
View reviewed changes
lib/pure/parsecfg.nim Outdated Show resolved Hide resolved
This was referenced Mar 25, 2021
Merged
Closed
@ringabout
Copy link
Member

ringabout commented Mar 25, 2021 •
edited
Loading

hi @ardek66
Since #17505 is merged, this PR should be able to move on. It needs a changelog. And since (1, 5).

And it is better to have a test too.

@ardek66 ardek66 marked this pull request as draft March 26, 2021 08:51
@ringabout ringabout requested a review from timotheecour March 27, 2021 09:09
@ardek66 ardek66 marked this pull request as ready for review March 27, 2021 16:24
@timotheecour timotheecour added the merge_when_passes_CI mergeable once green label Mar 28, 2021
ringabout
ringabout reviewed Mar 28, 2021
View reviewed changes
lib/pure/parsecfg.nim Outdated Show resolved Hide resolved
@timotheecour timotheecour merged commit 207bcab into nim-lang:devel Mar 28, 2021
@ardek66 ardek66 deleted the hacktoberfest branch March 28, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringabout ringabout ringabout approved these changes

@Araq Araq Araq left review comments

@timotheecour timotheecour timotheecour approved these changes

Assignees
No one assigned
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parsecfg does not expose a list of section names
5 participants
@ardek66 @juancarlospaco @Araq @ringabout @timotheecour