Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inline tiny proc #15498

Merged
merged 1 commit into from
Oct 6, 2020
Merged

inline tiny proc #15498

merged 1 commit into from
Oct 6, 2020

Conversation

juancarlospaco
Copy link
Collaborator

dom96
dom96 reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is doing this really worthwhile? The C compiler will likely auto-inline this for us so this just seems like a bunch of noise.

@juancarlospaco
Copy link
Collaborator Author

I am reading the diff of the generated C and I can confirm {.inline.} works Ok. 🤷

@ghost
Copy link

ghost commented Oct 6, 2020

I am reading the diff of the generated C and I can confirm {.inline.} works Ok. 🤷

C code is not what you should read, you should read assembly of the binary :)

@Araq
Copy link
Member

Araq commented Oct 6, 2020

Accepting for now but eventually we should enable LTO with -d:release and call it a day, time is money.

@Araq Araq merged commit 695f955 into nim-lang:devel Oct 6, 2020
@juancarlospaco juancarlospaco deleted the branch-name-here branch October 6, 2020 14:54
@juancarlospaco juancarlospaco mentioned this pull request Oct 15, 2020
Closed
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@juancarlospaco @mildred
inline tiny proc (nim-lang#15498)
b8dc4ea
@juancarlospaco juancarlospaco mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlospaco @Araq @dom96