-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reference fusion docs #15562
reference fusion docs #15562
Conversation
@@ -132,7 +132,10 @@ doc.body_toc_group = """ | |||
<a href="$theindexhref">Index</a> | |||
</li> | |||
<li> | |||
<a href="compiler/$theindexhref">Compiler docs</a> | |||
<a href="compiler/$theindexhref">compiler docs</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change of case here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's for consistency with import compiler/foo
(instead of import Compiler/foo
), ditto with import fusion/bar
instead of import Fusion/bar
I don't care much either way here.
still though, I would've preferred to get nim-lang/fusion#26 merged first as indicated in top post to make sure the link is valid
Can we have this reverted until nim-lang/fusion#26 actually got merged? Also the link is very misleading. It would always refer to the latest devel docs, while the installed/bundled version might be different. |
Note that fusion docs are actually built and is in the stdlib |
it got merged finally
we can change the link to fusion docs (master)
indeed, https://nim-lang.github.io/Nim/filepermissions.html is generated and should not be (at least not at that url). see nim-lang/RFCs#265 for a proposal on how to publish versioned docs for nim + fusion |
followup after nim-lang/fusion#24 (EDIT)
pending nim-lang/fusion#26 to make the link valid
fixes https://forum.nim-lang.org/t/6904