Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #15413 #15768

Merged
merged 4 commits into from
Oct 29, 2020
Merged

fixes #15413 #15768

merged 4 commits into from
Oct 29, 2020

Conversation

Araq
Copy link
Member

@Araq Araq commented Oct 29, 2020

No description provided.

@Araq Araq merged commit 87a60c1 into devel Oct 29, 2020
@Araq Araq deleted the araq-json-numbers branch October 29, 2020 16:33
@timotheecour
Copy link
Member

timotheecour commented Oct 29, 2020 •
edited
Loading

before I saw this PR I wrote another one (EDITL just pushed/closed it as #15776) that was similar but did so without introducing an extra isUnquoted bool param, instead it represented unparseable numbers as its string representation (taken from json, as here) appended with a trailing \0 char; since \0 is not a valid char in json, there is no ambiguity between a json string and a json number. It came with an API so client code never needs to know about this encoding.

a least on on 64 bit, however, sizeof(JsonObj) is the same (40) under both that trailing \0 approach as well as in isUnquoted approach, probably due to suboptimal padding.

@timotheecour timotheecour mentioned this pull request Oct 30, 2020
Closed
narimiran pushed a commit that referenced this pull request Nov 5, 2020
@Araq @narimiran
fixes #15413 (#15768)
645200a 
* fixes #15413

* better hide it properly

* see if this makes our list of important packages happy

(cherry picked from commit 87a60c1)
PMunch pushed a commit to PMunch/Nim that referenced this pull request Jan 6, 2021
@Araq @PMunch
fixes nim-lang#15413 (nim-lang#15768)
39f8bcd 
* fixes nim-lang#15413

* better hide it properly

* see if this makes our list of important packages happy
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@Araq @mildred
fixes nim-lang#15413 (nim-lang#15768)
e8f1f2d 
* fixes nim-lang#15413

* better hide it properly

* see if this makes our list of important packages happy
irdassis pushed a commit to irdassis/Nim that referenced this pull request Mar 16, 2021
@Araq @irdassis
fixes nim-lang#15413 (nim-lang#15768)
5ca5207 
* fixes nim-lang#15413

* better hide it properly

* see if this makes our list of important packages happy
@timotheecour timotheecour mentioned this pull request Mar 16, 2021
Merged
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@Araq @ardek66
fixes nim-lang#15413 (nim-lang#15768)
afeea05 
* fixes nim-lang#15413

* better hide it properly

* see if this makes our list of important packages happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araq @timotheecour