Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testcase for #15937 #15933

Merged
merged 5 commits into from
Dec 13, 2020
Merged

add testcase for #15937 #15933

merged 5 commits into from
Dec 13, 2020

Conversation

bung87
Copy link
Collaborator

@bung87 bung87 commented Nov 12, 2020

No description provided.

@ringabout ringabout closed this Nov 13, 2020
@ringabout ringabout reopened this Nov 13, 2020
@ringabout ringabout changed the title test for issue #15624 and PR #15915 for patch #13823 add testcase for #15937 Nov 13, 2020
@ringabout ringabout added the merge_when_passes_CI mergeable once green label Nov 13, 2020
@c-blake
Copy link
Contributor

c-blake commented Nov 13, 2020

It looks like when one adds the targets: the output expands from just the hashes/hashing to the same but with a bunch of [OK] lines? (EDIT: But maybe only on the JS backend?) Is that right? If so, maybe @bung87 can fix?

@bung87
Copy link
Collaborator Author

bung87 commented Nov 13, 2020

It looks like when one adds the targets: the output expands from just the hashes/hashing to the same but with a bunch of [OK] lines? (EDIT: But maybe only on the JS backend?) Is that right? If so, maybe @bung87 can fix?

let me handle this.

@c-blake
Copy link
Contributor

c-blake commented Nov 13, 2020

Ok. FWIW, I think I am wrong about the cause of the [OK] lines. They seem to show up running nim c -r thashes.nim as well, but not in the CI. Also, the freebsd/openbsd seem to only match in the lower 52 bits of hash. Not sure what is going on there, either.

@bung87
Copy link
Collaborator Author

bung87 commented Nov 13, 2020

https://github.com/nim-lang/Nim/pull/15933/checks?check_run_id=1396512871 fails, tests/vm/tslow_tables.nim test for issue #12195 "Compile time Table[A, B] lookup performance", not sure if related, maybe the CI container runs it too slow , the test case has a constant time out : 7 seconds

@c-blake
Copy link
Contributor

c-blake commented Nov 13, 2020

I've seen that timeout fail erroneously before. Someone should probably widen the timeout a little. It's hard since there is no real control over how busy is the underlying physical computer that runs the CI, but I think 2x longer at 14s would be fine.

@bung87
Copy link
Collaborator Author

bung87 commented Nov 13, 2020

OK, I'll consider that is unrelated, this PR task done .

tests/stdlib/thashes.nim Outdated Show resolved Hide resolved
@ringabout ringabout merged commit 5514b29 into nim-lang:devel Dec 13, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
* test for issue nim-lang#15624 and PR nim-lang#15915 for patch nim-lang#13823

* Update thashes.nim

no need mention PR nim-lang#15915, fixed in nim-lang#15937

* rebase to devel(issue maybe fixed), ignore ouputs

* Apply suggestions from code review

Co-authored-by: flywind <43030857+xflywind@users.noreply.github.com>
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* test for issue nim-lang#15624 and PR nim-lang#15915 for patch nim-lang#13823

* Update thashes.nim

no need mention PR nim-lang#15915, fixed in nim-lang#15937

* rebase to devel(issue maybe fixed), ignore ouputs

* Apply suggestions from code review

Co-authored-by: flywind <43030857+xflywind@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_when_passes_CI mergeable once green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants