move tests to testament #16101
Merged
move tests to testament #16101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ringabout
commented
Nov 23, 2020
•
ringabout
commented
- change two or three unittest style to doAssert
- use include because some symbols are not exported
- disable testing random module
narimiran
pushed a commit
that referenced
this pull request
Nov 25, 2020
* move tests to testament * minor * fix random * disable test random (cherry picked from commit cbc793b)
ringabout
added a commit
to ringabout/Nim
that referenced
this pull request
Nov 25, 2020
* move tests to testament * minor * fix random * disable test random
| @@ -665,36 +665,6 @@ proc prevPermutation*[T](x: var openArray[T]): bool {.discardable.} = | |||
|
|
|||
| result = true | |||
|
|
|||
| when isMainModule: | |||
There was a problem hiding this comment.
@xflywind
after PR we now have both tests/stdlib/ttables.nim and tests/collections/ttables.nim
(but it was indeed better to delay fixing this to a separate PR so this one stays a simple move operation)
these should be merged into a single one
|
to review this PR, you really need |
| let foo = parseUri("http://example.com") / "/baz" | ||
| doAssert foo.path == "/baz" | ||
|
|
||
| # bug found on stream 13/10/17 |
There was a problem hiding this comment.
for next time, prefer this style in 1 line:
block: # bug found on stream 13/10/17- more consistent with block logic
- more similar to
block: label - more similar to
test "VM and runtime shouldin unittests - more common and shorter
| @@ -52,7 +45,7 @@ suite "httpcore": | |||
| doAssert parseHeader("Accept: foo, bar, prologue") == (key: "Accept", value: @["foo", "bar", "prologue"]) | |||
| doAssert parseHeader("Accept: foo, bar, prologue, starlight") == (key: "Accept", value: @["foo", "bar", "prologue", "starlight"]) | |||
|
|
|||
| test "add empty sequence to HTTP headers": | |||
| block add_empty_sequence_to_HTTP_headers: | |||
There was a problem hiding this comment.
prefer this style:
block: "add empty sequence to HTTP headers"
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* move tests to testament * minor * fix random * disable test random
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* move tests to testament * minor * fix random * disable test random
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.