Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inc and dec are atomic in JS backend #16129

Merged
merged 14 commits into from
Nov 25, 2020
+10 −1
Merged

inc and dec are atomic in JS backend #16129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4d0d32e
fix rope index
ringabout Nov 23, 2020
8a11772
add testcase
ringabout Nov 23, 2020
fe2cae9
Merge remote-tracking branch 'upstream/devel' into ropes
ringabout Nov 23, 2020
280cd29
fix ropes format
ringabout Nov 23, 2020
2bee82b
Merge remote-tracking branch 'upstream/devel' into ropes
ringabout Nov 24, 2020
febf360
improve the documentation of ropes
ringabout Nov 24, 2020
d7fa0dc
docs
ringabout Nov 24, 2020
65c8ee6
make heapqueue support user-defined cmp function
ringabout Nov 24, 2020
75fd1ed
remove
ringabout Nov 25, 2020
ddc0fec
Revert "make heapqueue support user-defined cmp function"
ringabout Nov 25, 2020
1f7b6d3
Merge remote-tracking branch 'upstream/devel' into endians
ringabout Nov 25, 2020
992e3ad
Merge remote-tracking branch 'upstream/devel' into endians
ringabout Nov 25, 2020
2ce39db
inc and dec are atomic in JS backend
ringabout Nov 25, 2020
033351c
add simple testcase
ringabout Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/system.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,7 +1774,7 @@ when not defined(nimscript):
when not declared(sysFatal):
include "system/fatal"

when notJSnotNims:
when not defined(nimscript):
{.push stackTrace: off, profiler: off.}

proc atomicInc*(memLoc: var int, x: int = 1): int {.inline,
Expand Down
9 changes: 9 additions & 0 deletions tests/system/tatomics1.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
discard """
target: "c cpp js"
"""

var x = 10
atomicInc(x)
doAssert x == 11
atomicDec(x)
doAssert x == 10