Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions for jsconsole #16460

Merged
merged 8 commits into from
Dec 30, 2020
Merged

Add assertions for jsconsole #16460

merged 8 commits into from
Dec 30, 2020

Conversation

juancarlospaco
Copy link
Collaborator

@juancarlospaco juancarlospaco commented Dec 24, 2020 •
edited
Loading

  • Add assertions for jsconsole.
  • Generates a console.assert(expresion, message);. You can keep using normal assertions too.
  • Changelog, since, doc with links, runnableExamples, etc.

timotheecour
timotheecour reviewed Dec 24, 2020
View reviewed changes
lib/js/jsconsole.nim Outdated Show resolved Hide resolved
timotheecour
timotheecour reviewed Dec 24, 2020
View reviewed changes
lib/js/jsconsole.nim Outdated Show resolved Hide resolved
timotheecour
timotheecour reviewed Dec 24, 2020
View reviewed changes
lib/js/jsconsole.nim Outdated Show resolved Hide resolved
@Araq Araq merged commit b8658a3 into nim-lang:devel Dec 30, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@juancarlospaco @mildred
Add assertions for jsconsole (nim-lang#16460)
721bdce
@timotheecour timotheecour mentioned this pull request Mar 8, 2021
Closed
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@juancarlospaco @ardek66
Add assertions for jsconsole (nim-lang#16460)
e498f88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheecour timotheecour timotheecour left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancarlospaco @timotheecour @Araq