fix #16469 vm float constants: do not conflate -0.0 and 0.0 #16470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
force-pushed
the
pr_fix_16469_float_vm_const
branch
3 times, most recently
from
7e9c57f to
7b2e876
Compare
Merged
ringabout
approved these changes
Dec 26, 2020
Araq
reviewed
Dec 27, 2020
timotheecour
force-pushed
the
pr_fix_16469_float_vm_const
branch
from
7b2e876 to
8aa6471
Compare
|
PTAL, comment resolved and it fixed i386 CI |
1 task
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…im-lang#16470) * fix nim-lang#16469 vm float constants: do not conflate -0.0 and 0.0 * fix test for 32bit
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…im-lang#16470) * fix nim-lang#16469 vm float constants: do not conflate -0.0 and 0.0 * fix test for 32bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note
this doesn't break the test introduced in #13787 which is a related issue