Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #16554 #16564

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Fix #16554 #16564

merged 1 commit into from
Jan 3, 2021

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Jan 3, 2021

fixes #16554

@Araq Araq merged commit 2aed418 into nim-lang:devel Jan 3, 2021
@metagn metagn deleted the patch-3 branch January 3, 2021 07:36
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@metagn @mildred
Fix nim-lang#16554 (nim-lang#16564)
9458198
ee7 added a commit to ee7/Nim that referenced this pull request Jan 30, 2021
@ee7
critbits: fix error from strictFuncs
02dfc87 
Previously, compiling a file containing just `import critbits` with
`nim c --experimental:strictFuncs` would produce the following error:
    critbits.nim(529, 6) Error: 'toCritBitTree' can have side effects

This was introduced by 2aed418 (nim-lang#16564).

Fixes: nim-lang#16873
@ee7 ee7 mentioned this pull request Jan 30, 2021
Merged
Araq pushed a commit that referenced this pull request Feb 1, 2021
@ee7
critbits: fix error from strictFuncs (#16877)
0b01edd 
Previously, compiling a file containing just `import critbits` with
`nim c --experimental:strictFuncs` would produce the following error:
    critbits.nim(529, 6) Error: 'toCritBitTree' can have side effects

This was introduced by 2aed418 (#16564).

Fixes: #16873
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@metagn @ardek66
Fix nim-lang#16554 (nim-lang#16564)
22b086f
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@ee7 @ardek66
critbits: fix error from strictFuncs (nim-lang#16877)
9f5f213 
Previously, compiling a file containing just `import critbits` with
`nim c --experimental:strictFuncs` would produce the following error:
    critbits.nim(529, 6) Error: 'toCritBitTree' can have side effects

This was introduced by 2aed418 (nim-lang#16564).

Fixes: nim-lang#16873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toCritBitTree funcs have wrong signature
2 participants
@metagn @Araq