-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unbundle fusion #16925
unbundle fusion #16925
Conversation
I kind of liked it... Can it be removed from nimble instead? |
I'm confused by your +1 and this comment ;-) I don't see the point in removing fusion from nimble; it should either be a separate nimble package (like all other packages) or it should be merged inside nim repo (ie same git history), anything else seems like a brittle hack to me. And I prefer the 1st option (separate nimble package) as an "extended batteries" option. |
Either way its a problem that needs to be resolved and I support your initiative :) |
5f7afbb
to
ea82b54
Compare
ping: I had to rebase because of conflict bitrot /cc @Araq
|
ea82b54
to
49d2b09
Compare
PTAL |
In followup PRs "finish.nim" (and also choosenim if that's still a thing) should offer to install the Fusion package. |
* unbundle fusion * changelog * address comment: `./koch fusion` calls nimble install fusion (at a fixed hash)
fixes nim-lang/fusion#25
nimble install fusion
or--path:/pathto/fusion/src
or--path:fusion:/pathto/fusion/src/fusion
(nim-lang/RFCs#291) (and possibly with a fixed hash/tagnimble install fusion@#1234
) is a much saner approach than copying fusion sources (at a fixed hash) to$nim/lib/fusion
, which can only cause problems down the line when user also hasnimble install fusion
as it'd lead to duplicate fusion modules (eg: link error if there's an exportc symbol, or surprising module resolution in case ofimport fusion/foo
)note, this doesn't preclude using fusion from within
tools/
orcompiler/
(refs nim-lang/fusion#22), in fact it makes it easier to, by avoiding the above mentioned issues of potential duplicate modules.future work
links
#16875 (comment)