Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbundle fusion #16925

Merged
merged 7 commits into from
Feb 11, 2021
Merged

unbundle fusion #16925

merged 7 commits into from
Feb 11, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Feb 3, 2021

fixes nim-lang/fusion#25

nimble install fusion or --path:/pathto/fusion/src or --path:fusion:/pathto/fusion/src/fusion (nim-lang/RFCs#291) (and possibly with a fixed hash/tag nimble install fusion@#1234) is a much saner approach than copying fusion sources (at a fixed hash) to $nim/lib/fusion, which can only cause problems down the line when user also has nimble install fusion as it'd lead to duplicate fusion modules (eg: link error if there's an exportc symbol, or surprising module resolution in case of import fusion/foo)

note, this doesn't preclude using fusion from within tools/ or compiler/ (refs nim-lang/fusion#22), in fact it makes it easier to, by avoiding the above mentioned issues of potential duplicate modules.

future work

links

The current plan is that we don't bundle Fusion anymore with Nim

#16875 (comment)

@planetis-m
Copy link
Contributor

I kind of liked it... Can it be removed from nimble instead?

@timotheecour
Copy link
Member Author

timotheecour commented Feb 3, 2021

I kind of liked it... Can it be removed from nimble instead?

I'm confused by your +1 and this comment ;-)

I don't see the point in removing fusion from nimble; it should either be a separate nimble package (like all other packages) or it should be merged inside nim repo (ie same git history), anything else seems like a brittle hack to me. And I prefer the 1st option (separate nimble package) as an "extended batteries" option.

@planetis-m
Copy link
Contributor

Either way its a problem that needs to be resolved and I support your initiative :)

@timotheecour
Copy link
Member Author

timotheecour commented Feb 10, 2021

ping: I had to rebase because of conflict bitrot /cc @Araq

The current plan is that we don't bundle Fusion anymore with Nim

changelog.md Outdated Show resolved Hide resolved
@timotheecour
Copy link
Member Author

PTAL

@Araq
Copy link
Member

Araq commented Feb 11, 2021

In followup PRs "finish.nim" (and also choosenim if that's still a thing) should offer to install the Fusion package.

@Araq Araq merged commit b7dd8e7 into nim-lang:devel Feb 11, 2021
@timotheecour timotheecour deleted the pr_unbundle_fusion branch February 12, 2021 02:26
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
* unbundle fusion
* changelog
* address comment: `./koch fusion` calls nimble install fusion (at a fixed hash)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instead of copyDir(fustion, stdlib/lib), update --path
3 participants