[backport:1.4] JS cstring null fixes #16979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason this is set to be backported to 1.4 is because #14158, the PR that removed null seqs/strings ( |
|
Does this conflict with the 1.4.4 release candidate? Having nil cstrings without noticing are pretty common in JS, and strings being |
|
@hlaaftana The release is scheduled for next week and this commit is likely to make it into 1.4.4. Ping @narimiran |
narimiran
pushed a commit
that referenced
this pull request
Feb 17, 2021
* [backport:1.4] JS cstring null fixes * fix JS move string * make it look cleaner (cherry picked from commit 81533a0)
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* [backport:1.4] JS cstring null fixes * fix JS move string * make it look cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16674, fixes #16686
I special cased
cstringfor AppendStrStr here because it's not disruptive, butadd(var cstring, cstring)could just be emitted/asm'd and not use a magic, or it could as well just not exist since it wasn't documented before and it's very easy to wrap+=yourself. This is good enough now though.Also fixed
moveturning stringsnull.