fix #17325 linux 32bit CI; fix #17085 flaky test #17469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
timotheecour
force-pushed
the
pr_fix_linux32bit
branch
2 times, most recently
from
4623385 to
0c9e94c
Compare
timotheecour
changed the title
timotheecour
commented
Mar 23, 2021
|
|
||
| proc initFromJson[T: SomeInteger](dst: var T; jsonNode: JsonNode, jsonPath: var string) = | ||
| when T is uint|uint64: | ||
| when T is uint|uint64 or (not defined(js) and int.sizeof == 4): |
Member
Author
There was a problem hiding this comment.
this logic can be refined in future work, but at least it's good to re-enable a non-broken i386
Araq
reviewed
Mar 23, 2021
… a warning causing CI to fail with mismatched output
timotheecour
force-pushed
the
pr_fix_linux32bit
branch
from
0c9e94c to
3b9ec15
Compare
ringabout
approved these changes
Mar 24, 2021
narimiran
added a commit
that referenced
this pull request
Mar 24, 2021
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @narimiran
note, the underlying issue with 32bit linux CI was due to upstream broken packages and lasted from 1 to 2 weeks but the upstream issue has now been fixed. In the meantime other tests were added that were broken in i386; this PR fixes those tests