Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #12282 distinct now does not create erroneous copy in VM #17594

Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix #12282 distinct now does not create erroneous copy in VM #17594

merged 1 commit into from
Mar 31, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Mar 31, 2021 •
edited
Loading

fix #12282, a long time annoyance

@Araq Araq merged commit 8ee0eda into nim-lang:devel Mar 31, 2021
@timotheecour timotheecour deleted the pr_fix_12282_vm_distinct_copy branch March 31, 2021 08:20
@timotheecour timotheecour mentioned this pull request Mar 31, 2021
Closed
Araq pushed a commit that referenced this pull request May 10, 2023
@ringabout @timotheecour
fix #9423 followup #17594: distinct generics now work in VM (#21816)
deaf684 
* fix #9423 distinct generics now work in vm

* fixes cpp tests

---------

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
capocasa pushed a commit to capocasa/Nim that referenced this pull request May 15, 2023
@ringabout @timotheecour @capocasa
fix nim-lang#9423 followup nim-lang#17594: distinct generics now work…
67bf57f 
… in VM (nim-lang#21816)

* fix nim-lang#9423 distinct generics now work in vm

* fixes cpp tests

---------

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
capocasa pushed a commit to capocasa/Nim that referenced this pull request May 16, 2023
@ringabout @timotheecour @capocasa
fix nim-lang#9423 followup nim-lang#17594: distinct generics now work…
82bae34 
… in VM (nim-lang#21816)

* fix nim-lang#9423 distinct generics now work in vm

* fixes cpp tests

---------

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
narimiran pushed a commit that referenced this pull request Jun 19, 2023
@ringabout @narimiran
fix #9423 followup #17594: distinct generics now work in VM (#21816)
04d0716 
* fix #9423 distinct generics now work in vm

* fixes cpp tests

---------

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
(cherry picked from commit deaf684)
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @timotheecour @bung87
fix nim-lang#9423 followup nim-lang#17594: distinct generics now work…
23e6a97 
… in VM (nim-lang#21816)

* fix nim-lang#9423 distinct generics now work in vm

* fixes cpp tests

---------

Co-authored-by: Timothee Cour <timothee.cour2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type conversion of distinct creates erroneous copy in VM
2 participants
@timotheecour @Araq