Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sum functions #18438

Closed
wants to merge 7 commits into from
Closed

Add sum functions #18438

wants to merge 7 commits into from

Conversation

planetis-m
Copy link
Contributor

Alternative to #16004, addresses most review comments. If it's going to be deprecated, I can adopt the package, either works for me. I am the original author.

lib/std/sums.nim Outdated Show resolved Hide resolved
lib/std/sums.nim Outdated Show resolved Hide resolved
tests/stdlib/tsums.nim Outdated Show resolved Hide resolved
tests/stdlib/tsums.nim Outdated Show resolved Hide resolved
tests/stdlib/tsums.nim Outdated Show resolved Hide resolved
lib/std/sums.nim Outdated Show resolved Hide resolved
tests/stdlib/tsums.nim Outdated Show resolved Hide resolved
@konsumlamm
Copy link
Contributor

While I like the idea of having different accurate summation functions, I don't think they should be in the standard library (and I'm not sure why this module was added in the first place), but rather a nimble package.

The only real use of std/sums I could find (after a quick GitHub search) was in a test, where it only seems to be used to test passing as openArray (https://github.com/bpr/vla/blob/master/tests/tests.nim). So, similar to #18395 (comment), I'm in favor deprecating std/sums, as it's only very rarely used (definitely not enough to justify having it in the standard library).

@planetis-m
Copy link
Contributor Author

Alright, will do that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants