Revert #17398 and #17402

[narimiran]

Another breaking change which shouldn't be part of Nim 1.6

[juancarlospaco]

If someone really relies on broken behaviours and not asserting its inputs,
then that person should do a tiny "shim", instead of keeping the bad code for everyone,
is very cheap to check if a char is DirSep. 🤷

template getHomeDirShim*(): string =
  let s = getHomeDir()
  if s[^1] == '/': s else: s & '/'

[timotheecour]

or, using getHomeDir().normalizePathEnd(trailingSep = false)

[kaushalmodi]

Wouldn't it be better to create a version-1p6 branch and undo all the breaking commits there? I thought devel was targeting the latest and greatest future Nim version.

[Araq]

Wouldn't it be better to create a version-1p6 branch and undo all the breaking commits there? I thought devel was targeting the latest and greatest future Nim version.

We're considering it.

[timotheecour]

Wouldn't it be better to create a version-1p6 branch and undo all the breaking commits there? I thought devel was targeting the latest and greatest future Nim version.

this is would be much better than reverting these commit, likewise with other reverts that are currently pending and other similar reverts that were made in 1.5; but we don't even need to undo those commits in that branch and in fact it's better not to as it allows gradual migration, see #18486

[Araq]

So previously the code used a trailing dir on purpose. Calling this a "bugfix" then is a bit of stretch...

[Araq]

then that person should do a tiny "shim", instead of keeping the bad code for everyone

And why is it suddenly "bad code"? It used to work and could continue to work...

[timotheecour]

See #18513 ({.migrated:... .}) which provides a much better solution, by issuing a new migration warning for these 3 APIs, which allows you to find at CT all the callsites that need to be checked; the migration warning can be turned off on a per-API basis (eg -d:nimMigratedGetHomeDir) which should make the migration a lot easier.

And why is it suddenly "bad code"? It used to work and could continue to work...

because it was inconsistent both with all other languages and all other APIs in nim that return a dir, see long list here: #17393 (comment), consistency is still a thing.

[Araq]

because it was inconsistent both with all other languages and all other APIs in nim that return a dir, see long list here: #17393 (comment), consistency is still a thing.

But now it's not consistent with its own previous behavior anymore... Great consistency here.