envPairs works in vm, nims #18615
Merged
envPairs works in vm, nims #18615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
commented
Jul 30, 2021
| @@ -19,29 +21,3 @@ block: | |||
| if not isWindows: | |||
| doAssert cwd.isAbsolute | |||
| doAssert relativePath(getCurrentDir() / "foo", "bar") == "../foo" | |||
|
|
|||
| import std/sequtils | |||
There was a problem hiding this comment.
these are all covered in tosenv
timotheecour
commented
Jul 30, 2021
| var gEnv {.importc: "environ", header: "<stdlib.h>".}: cstringArray | ||
| var gEnv {.importc: "environ".}: cstringArray | ||
|
|
||
| iterator envPairsImpl(): tuple[key, value: string] {.tags: [ReadEnvEffect].} = |
There was a problem hiding this comment.
pure re-indentation until this point
timotheecour
added
the
Ready For Review
|
ping @Araq |
2 tasks
timotheecour
force-pushed
the
pr_envPairs_vm
branch
from
0e21cd8 to
ee3cfb9
Compare
|
ping @Araq before this bitrots again, I rebased after this had bit-rotted |
|
@Araq ok to backport this to 1.6 branch? fits well with other improvements to environment variables made in this release, so that we can claim:
instead of some weird subset of this statement |
|
I think it's too risky as the diff is quite large, even ignoring the indentation changes. |
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* envPairs works in vm, nims * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all osenv APIs now work and are tested in all backends (c,cpp,vm,nims,js with -d:nodejs)
(note: before PR, getEnv, existsEnv, delEnv, putEnv worked in VM but not envPairs; etc)