Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] add v1.6 changelog #18932

Merged
merged 6 commits into from
Oct 13, 2021
Merged

Conversation

narimiran
Copy link
Member

This will be used (linked) from the release article on our website.

Author: @timotheecour

@arnetheduck
Copy link
Contributor

In general, it would be important to include a prominent list of known breaking changes - rn it's hard to find them as they're hidden between bugs and feature additions.

@dom96
Copy link
Contributor

dom96 commented Oct 1, 2021

In general, it would be important to include a prominent list of known breaking changes - rn it's hard to find them as they're hidden between bugs and feature additions.

Indeed, that is how we used to do release notes... last I heard we stopped because we don't want people to think that we are breaking things, which is just silly IMO.

@Araq
Copy link
Member

Araq commented Oct 1, 2021

Indeed, that is how we used to do release notes... last I heard we stopped because we don't want people to think that we are breaking things, which is just silly IMO.

I don't think that's what I said, but where are the breaking changes for 1.6 anyway? There is one regarding jsonutils which we'll rollback...

@arnetheduck
Copy link
Contributor

want people to think

that sounds really odd though, not at all what I'd expect - ie when you break things, presumably you've thought it through and decide that the pain it causes is worth it, and can stand behind the decision.

re breaking changes, I'm not sure - there was a long list in the devel release notes - if they have all been addressed, fantastic!

I am also thinking about the chronos issue with callbacks, but that's lent which presumably already broke working code in 1.4?

@Araq
Copy link
Member

Araq commented Oct 1, 2021

I am also thinking about the chronos issue with callbacks, but that's lent which presumably already broke working code in 1.4?

Correct.

changelogs/changelog_1_6_0.md Outdated Show resolved Hide resolved
changelogs/changelog_1_6_0.md Outdated Show resolved Hide resolved
changelogs/changelog_1_6_0.md Show resolved Hide resolved
@disruptek
Copy link
Contributor

You broke CPS and my codebase at work. Does that help?

@Araq
Copy link
Member

Araq commented Oct 13, 2021

You broke CPS and my codebase at work. Does that help?

No, why did we break these... I cannot document breaking changes I've no clue about.

@narimiran narimiran merged commit f93bfc0 into nim-lang:devel Oct 13, 2021
@narimiran narimiran deleted the v16-changelog branch October 13, 2021 18:33
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants