Fixing more nnkBracketExpr not being checked in hasCustomPragma calling getImpl of nnkBracketExpr #19450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Araq This is a follow-up of #19427
It's mostly the same issue : getImpl being called on nnkBracketExpr without checking. I can only fix it where I encounter it (necessary to fix moigagoo/norm#132). but there may other.
I'm wondering if a better fix wouldn't be to check for nnkBracketExpr in a
getImpl
wrapper (since getImpl is magic) like :but I do not know the ramification of such a change; or if it's better or worse than adding manual check whenever the issue arise.