enable style:usages for stdlib tests [backport: 1.6] #19715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
changed the title
ringabout
commented
Apr 12, 2022
| @@ -150,25 +150,25 @@ proc tryExec*(db: DbConn, query: SqlQuery, args: varargs[string, `$`]): bool {. | |||
| tags: [ReadDbEffect, WriteDbEffect].} = | |||
| ## tries to execute the query and returns true if successful, false otherwise. | |||
| var q = dbFormat(query, args) | |||
| return mysql.realQuery(PMySQL db, q, q.len) == 0'i32 | |||
| return mysql.real_query(PMySQL db, q, q.len) == 0'i32 | |||
There was a problem hiding this comment.
I would like to use camelCase, however the whole file of mysql.nim uses snake_case. So I decide to live with it now.
There was a problem hiding this comment.
what we've done in such cases is to separate the pure C API into a private module that does nothing else than importc, then add a wrapper on top that makes the wrapper convenient to use from nim - this works pretty well because it also separates the responsibilities of the various modules along a clean line
Araq
reviewed
Apr 12, 2022
Araq
reviewed
Apr 12, 2022
Araq
reviewed
Apr 12, 2022
Araq
reviewed
Apr 12, 2022
|
See my remarks. Otherwise it's excellent. |
narimiran
pushed a commit
that referenced
this pull request
May 24, 2022
* enable style:usages for stdlib tests * freeAddrInfo * more tests * importc * bufSize * fix more * => parseSql and renderSql (cherry picked from commit 98cebad)
ringabout
added a commit
that referenced
this pull request
Dec 1, 2022
* enable style:usages for stdlib tests * freeAddrInfo * more tests * importc * bufSize * fix more * => parseSql and renderSql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.