Correctly import libcrypto functions using dynlib #19881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Jun 13, 2022
| @@ -93,6 +93,9 @@ else: | |||
|
|
|||
| import dynlib | |||
|
|
|||
| {.pragma: lcrypto, cdecl, dynlib: DLLUtilName, importc.} | |||
There was a problem hiding this comment.
(most of) these should be raises: [], noSideEffect as well - don't remember if SSL has globals or not which would affect side effects
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL methods exposed in #13131 were not properly imported from libcrypto, resulting in failure to load them dynamically.
I have solved this as mentioned in making timotheecour#64 (comment).
Although I haven't replaced all occurences of the older pragma, this new pragma could lead people to not make mistakes like this in the future.
Also I have removed
PEVP_MDbecause it was redundant.