Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use arrow precedence in spec #20166

Merged
merged 2 commits into from
Sep 6, 2022
Merged

use arrow precedence in spec #20166

merged 2 commits into from
Sep 6, 2022

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Aug 5, 2022

closes #8759

@metagn metagn changed the title test using arrow precedence in spec use arrow precedence in spec Aug 12, 2022
@metagn
Copy link
Collaborator Author

metagn commented Aug 12, 2022

Updated to add test for #8759. Ready to be merged.

@metagn metagn closed this Aug 12, 2022
@metagn metagn reopened this Aug 12, 2022
@metagn
Copy link
Collaborator Author

metagn commented Aug 30, 2022

Forgot to mention: Not backporting because it might create an inconsistency between patches of older versions. It's fine either way though as it doesn't seem like code would be affected.

@Araq Araq merged commit 801eb3c into nim-lang:devel Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 801eb3c

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164034 lines; 12.057s; 842.488MiB peakmem

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
* test using arrow precedence in spec

refs nim-lang#8759

* add test for nim-lang#8759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[parser] a => counter+=1 parsed as (a => counter) += 1, violating the spec, and causing issues with =>
2 participants