Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #20694; range check the parameter of the proc quit #20718

Closed
wants to merge 16 commits into from
Closed

fixes #20694; range check the parameter of the proc quit #20718

wants to merge 16 commits into from

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Oct 31, 2022 •
edited
Loading

fixes #20694

bung87
bung87 reviewed Oct 31, 2022
View reviewed changes
lib/system.nim Outdated Show resolved Hide resolved
@ringabout ringabout marked this pull request as draft November 1, 2022 04:18
@ringabout ringabout mentioned this pull request Nov 1, 2022
Merged
@ringabout ringabout marked this pull request as ready for review November 1, 2022 14:48
@Araq
Copy link
Member

Araq commented Nov 3, 2022 •
edited
Loading

Very invasive change. Please implement my suggestion instead.

ringabout added a commit that referenced this pull request Nov 3, 2022
@ringabout
Revert "make system/fatal importable (#20718)"
0a7ef1c 
This reverts commit d735c44.
@ringabout ringabout mentioned this pull request Nov 3, 2022
Merged
@ringabout
Copy link
Member Author

Sure, I'm on it.

Araq pushed a commit that referenced this pull request Nov 4, 2022
@ringabout
revert #20719; relieve std/assertions of the sysFatal dep (#20743)
12a20b9 
* Revert "make `system/fatal` importable (#20718)"

This reverts commit d735c44.

* relieve `std/assertions` of the sysFatal dep
@ringabout ringabout closed this Nov 4, 2022
@ringabout ringabout deleted the pr#20694 branch November 4, 2022 12:50
@ringabout
Copy link
Member Author

Succeeded by #20753

capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
revert nim-lang#20719; relieve std/assertions of the sysFatal dep (…
a493176 
…nim-lang#20743)

* Revert "make `system/fatal` importable (nim-lang#20718)"

This reverts commit d735c44.

* relieve `std/assertions` of the sysFatal dep
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
revert nim-lang#20719; relieve std/assertions of the sysFatal dep (…
8922ebd 
…nim-lang#20743)

* Revert "make `system/fatal` importable (nim-lang#20718)"

This reverts commit d735c44.

* relieve `std/assertions` of the sysFatal dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-blake c-blake c-blake left review comments

@bung87 bung87 bung87 left review comments

@arnetheduck arnetheduck arnetheduck left review comments

@Araq Araq Araq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid type in `importc: "exit"'
5 participants
@ringabout @Araq @arnetheduck @bung87 @c-blake