fix bugs with dot & call operators [backport] #20931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
changed the title
metagn
changed the title
|
Can someone explain to me what the nimsuggest tests mean? I can't find documentation of it anywhere. At least I can guess what change caused the test to change ( |
|
Ok, so from what I understand in that test, there is no duplicate highlighting of the generic type now, which I'm assuming is not a problem, so I'll just adapt the test. Correct me if I'm wrong. |
metagn
changed the title
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
survivorm
pushed a commit
to survivorm/Nim
that referenced
this pull request
Feb 28, 2023
* better error messages for dot operators [backport] fixes nim-lang#13063 * also fixes nim-lang#7777 * fix nim-lang#6981 and nim-lang#9831 too * fix * minor improvement * sus test fixes * make test multiplatform lol * fix nimsuggest test, extra improvements
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
Mar 31, 2023
* better error messages for dot operators [backport] fixes nim-lang#13063 * also fixes nim-lang#7777 * fix nim-lang#6981 and nim-lang#9831 too * fix * minor improvement * sus test fixes * make test multiplatform lol * fix nimsuggest test, extra improvements
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
* better error messages for dot operators [backport] fixes nim-lang#13063 * also fixes nim-lang#7777 * fix nim-lang#6981 and nim-lang#9831 too * fix * minor improvement * sus test fixes * make test multiplatform lol * fix nimsuggest test, extra improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13063, fixes #7777, fixes #6981, fixes #9831
"Wrong" behavior of
newSeq[int]-type calls fixed as well, discovered because of these issues, they should not go throughnfExprCall