Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generic define pragma + string alias #20979

Merged
merged 4 commits into from
Dec 13, 2022
Merged

generic define pragma + string alias #20979

merged 4 commits into from
Dec 13, 2022

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Nov 30, 2022 •
edited
Loading

@metagn metagn closed this Nov 30, 2022
@metagn metagn reopened this Nov 30, 2022
@metagn metagn closed this Nov 30, 2022
@metagn metagn reopened this Nov 30, 2022
@Araq
Copy link
Member

Araq commented Nov 30, 2022

Already this --define mechanism is overused and terrible. Adding a namespace to the mechanism doesn't improve it. At least make it simpler and don't support chars and floats.

@metagn
Copy link
Collaborator Author

metagn commented Nov 30, 2022

Can I make strdefine etc just alias to define to make it simpler as well? And maybe only document define and not the rest

@Varriount Varriount requested a review from Araq November 30, 2022 21:28
@Varriount Varriount added the Requires Araq To Merge PR should only be merged by Araq label Nov 30, 2022
@Araq Araq merged commit 9a50033 into nim-lang:devel Dec 13, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 9a50033

Hint: mm: orc; opt: speed; options: -d:release
165562 lines; 8.054s; 612.195MiB peakmem

survivorm pushed a commit to survivorm/Nim that referenced this pull request Feb 28, 2023
@metagn @survivorm
generic define pragma + string alias (nim-lang#20979)
90ca572 
* generic `define` pragma + string alias

* clean

* add tests and document

* remove char/float, minimize changelog
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@metagn @capocasa
generic define pragma + string alias (nim-lang#20979)
7bdd0eb 
* generic `define` pragma + string alias

* clean

* add tests and document

* remove char/float, minimize changelog
bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@metagn @bung87
generic define pragma + string alias (nim-lang#20979)
c07ae38 
* generic `define` pragma + string alias

* clean

* add tests and document

* remove char/float, minimize changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
Requires Araq To Merge PR should only be merged by Araq
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metagn @Araq @Varriount