LTO improvements - fix #15578 #21679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
May 15, 2023
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
May 16, 2023
narimiran
pushed a commit
that referenced
this pull request
Jun 15, 2023
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LTO is broken on Mac, meaning no one uses it due to cross platform concerns, see Pebaz/nimporter#51 and
Also uses Clang ThinLTO if lto_incremental is set https://clang.llvm.org/docs/ThinLTO.html
Addressing the discussion on whether the flag is wanted or not (#15578 and nim-lang/RFCs#278) is not in scope, this just fixes the bug of the current status quo.