fix #14254

[metagn]

fixes #14254

Not super clean but can't think of a better solution

[metagn]

Package failure is because

proc T(x: int): float = x.float

proc foo[T](x: int) =
  echo x.T

foo[uint](123) # 123.0

now behaves like

proc T(x: int): float = x.float

block:
  type T = uint
  proc foo(x: int) =
    echo x.T

  foo(123) # 123

which to me seems like the more consistent behavior. We either patch the package (to use a different name for the generic param) or we don't fix this bug I think.

[metagn]

Ok yep, this is an inconsistency

proc T(x: int): float = x.float

proc foo[T](x: int) =
  echo typeof T(x) # uint
  echo typeof x.T # float

foo[uint](123)

Made a PR to the package: andreaferretti/neo#53

[Araq]

Feel free to fork the package and delegate "important_packages" to the fork or to disable the package for testing so that we can move on with this bugfix. It's pretty nice to have for v2.0.

[metagn]

Done, CI failure unrelated

[github-actions]

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 641e34b

Hint: mm: orc; opt: speed; options: -d:release
167395 lines; 8.708s; 613.293MiB peakmem