Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds =destroy T support for strings and seqs #22167

Merged
merged 3 commits into from
Jun 27, 2023
Merged

adds =destroy T support for strings and seqs #22167

merged 3 commits into from
Jun 27, 2023

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Jun 27, 2023 •
edited
Loading

follow up #22147

signature

N_NIMCALL(void, foo)(tySequence s)

@ringabout ringabout marked this pull request as draft June 27, 2023 08:09
@ringabout ringabout marked this pull request as ready for review June 27, 2023 10:59
@Araq Araq merged commit e422b3c into devel Jun 27, 2023
@Araq Araq deleted the pr_des2 branch June 27, 2023 11:07
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from e422b3c

Hint: mm: orc; opt: speed; options: -d:release
168075 lines; 8.620s; 612.223MiB peakmem

bung87 pushed a commit to bung87/Nim that referenced this pull request Jul 29, 2023
@ringabout @bung87
adds =destroy T support for strings and seqs (nim-lang#22167)
af8fe5b 
* adds =destroy T support for strings and seqs

* fixes system

* fixes tests
@ringabout ringabout mentioned this pull request Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq