remove bad type inference behavior for enum identifiers (2.0) #23593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is red though. |
|
I missed one more failing test, which was from #20091 which introduced the bad behavior in the first place (and again works in devel because of ambiguous identifier resolution). Hopefully it should pass now. |
47 tasks
|
@metagn What is the status of this one? Can you maybe take another look, so it'll be part of 2.0.6? |
|
Needs to combine with #23597 to deal with #23596 and there is also #23611 which is lower priority but needs a substantial revert to work. In any case touching this behavior at all breaks something, just maybe people haven't encountered the specific breaking cases yet. This is why I didn't update the backport version yet, it's too volatile with regards to breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts #23588 to version-2-0 branch
The test for #21257 is changed to give an ambiguous identifier error (the original issue was that it segfaulted), this is because ambiguous identifier resolution (#23123) is not in the 2.0 branch.