fix segfault with gensym node instantiation #24050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #24048
Generic lambdas get instantiated via
replaceTypesInBody
which callsreplaceTypeVarsN
on the body of the lambda. This body can contain sym nodes of gensym symbols generated by macros, which havenil
type. But a piece of code inreplaceTypeVarsN
checks whether the type of a symbol is equal tovoid
without checking if it'snil
first, which causes a segfault. Now it also checks that the type of the symbol isn'tnil
for it to bevoid
.