fix calls to implicitly generic params in generic contexts #24246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple remaining bugs after #24005, #24065 for proc parameters with implicit generic types:
containsUnresolvedType
was introduced that purposefully excluded typeclasses, but implicitly generic proc params can have typeclass type annotated withtfImplicitTypeParam
. To fix this, we includetfImplicitTypeParam
andtfGenericTypeParam
into the flags that are considered unresolved (previously onlytfUnresolved
).x is T
wherex
has an unresolved type only delayed evaluation ifx
was a type itself, i.e. it didn't work properly ifx
is a regular value. This is now fixed by performing the same check for both non-typedesc types and typedesc types.