fixes #23668; migrates from pcre to pcre2 #24405
Open
+758
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringabout
commented
Nov 4, 2024
arnetheduck
reviewed
Nov 5, 2024
| # passed from pcre_compile(). Those that are compatible with JIT execution are | ||
| # flagged with J. | ||
|
|
||
| PCRE2_MAJOR* = 10 |
There was a problem hiding this comment.
shouldn't this be the version of the dynamically loaded pcre2 library? the version on the OS might be anything, including much older ones?
There was a problem hiding this comment.
How to load a C define from a dynamic library?
#define PCRE2_MAJOR @PCRE2_MAJOR@
#define PCRE2_MINOR @PCRE2_MINOR@
#define PCRE2_PRERELEASE @PCRE2_PRERELEASE@
#define PCRE2_DATE @PCRE2_DATE@There was a problem hiding this comment.
libraries usually have a function for that, to load it dynamically - even if you compile on one system, another system you run the compiled binary will have a different version making these defines entirely meaningless at best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23668
Most of
tre.nimandtnre.nimpassed and didn't leak when checked with valgrind.TODO
Useful links
PCRE2Project/pcre2#51 (comment)
php/php-src#2857
i3/i3#4682 (comment)
https://copilot.microsoft.com