Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install older version of nimcuda for arraymancer #24496

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

metagn
Copy link
Collaborator

@metagn metagn commented Dec 2, 2024

Attempt to fix CI failure, refs #24495 (comment), alternative is to use a commit version like SciNim/nimcuda@bc65375

@Clonkk
Copy link
Contributor

Clonkk commented Dec 2, 2024

@Vindaar are you aware of the issue with latest nimcuda ?

@Vindaar
Copy link
Contributor

Vindaar commented Dec 2, 2024

Kind of? Recently I've seen weird installation issues across a few repositories (weave, arraymancer and maybe something else, don't remember). I assumed it was a nimble issue (the error messages were not very helpful in each case). I can investigate, +but here I also don't understand how the fix is a nimcuda issue.+

edit: misread the last part of the fix and that 0.2.1 is not the latest anymore, heh. I'll investigate

@Clonkk
Copy link
Contributor

Clonkk commented Dec 2, 2024

Could it be related to how Nimble resolves the commit hash used to compile dependencies?

I have had issue on atlas (if they use the same algo?) when not using MaxVer

@Vindaar
Copy link
Contributor

Vindaar commented Dec 2, 2024

Could it be related to how Nimble resolves the commit hash used to compile dependencies?

I have had issue on atlas (if they use the same algo?) when not using MaxVer

Had a short look. The issue here is indeed just an issue with a) how nimcuda now handles the wrapper (need to supply paths to the CUDA installation at CT due to SciNim/nimcuda#27) and b) the fact that arraymancer (still) always builds with CUDA support. The latter was never a problem when nimcuda only loaded the cuda libraries at runtime in case they were actually needed.

I'll likely make a -d:cuda switch mandatory for arraymancer to build with CUDA support in the future.

@metagn
Copy link
Collaborator Author

metagn commented Dec 3, 2024

Merging for now

@metagn metagn merged commit 33dc236 into nim-lang:devel Dec 3, 2024
15 checks passed
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 33dc236

Hint: mm: orc; opt: speed; options: -d:release
177926 lines; 8.676s; 653.449MiB peakmem

narimiran pushed a commit that referenced this pull request Dec 9, 2024
Attempt to fix CI failure, refs
#24495 (comment),
alternative is to use a commit version like
SciNim/nimcuda@bc65375

(cherry picked from commit 33dc236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants