isolate and rematch generic converters to get bindings #24867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes nim-lang#4554, fixes nim-lang#10900, fixes nim-lang#13843, fixes nim-lang#19471, fixes nim-lang#19517
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
Apr 14, 2025
fixes #4554, fixes #10900, fixes #13843, fixes #19471, fixes #19517 Instead of matching generic converters to their arguments using the full call match bindings, a new match is created for them (from which the bindings are used to instantiate the converter return type). Then when instantiating generic converters, they are matched to their argument again to get their bindings again instead of using the call bindings. This prevents generic converters which match more than once from interfering with each other's bindings. (cherry picked from commit 334f96c)
|
The examples from wnim are not compiled. I suspect in connection with this change...
|
Araq
pushed a commit
that referenced
this pull request
Apr 24, 2025
refs #24867, #24867 (comment) The argument node of the converter can be wrapped in [hidden `addr` or subtype conversion nodes](https://github.com/nim-lang/Nim/blob/dc100c5caa673b039155e9e5d4c7fc0c239f4eb5/compiler/sigmatch.nim#L2327-L2335) which have to be skipped when matching the type again, since the type of the node is the uninstantiated type taken from the proc parameter.
narimiran
pushed a commit
that referenced
this pull request
May 5, 2025
refs #24867, #24867 (comment) The argument node of the converter can be wrapped in [hidden `addr` or subtype conversion nodes](https://github.com/nim-lang/Nim/blob/dc100c5caa673b039155e9e5d4c7fc0c239f4eb5/compiler/sigmatch.nim#L2327-L2335) which have to be skipped when matching the type again, since the type of the node is the uninstantiated type taken from the proc parameter. (cherry picked from commit 8c9a645)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4554, fixes #10900, fixes #13843, fixes #19471, fixes #19517
Instead of matching generic converters to their arguments using the full call match bindings, a new match is created for them (from which the bindings are used to instantiate the converter return type). Then when instantiating generic converters, they are matched to their argument again to get their bindings again instead of using the call bindings. This prevents generic converters which match more than once from interfering with each other's bindings.