Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dynlink with OpenSSL >1.1.0. Added loadLibPattern. #5069

Merged
merged 3 commits into from
Nov 30, 2016

Conversation

yglukhov
Copy link
Member

@yglukhov yglukhov commented Nov 29, 2016

  • Don't try to link and call some OpenSSL functions if not available.
  • Support dynlibOverride flag in compileOption.
  • libCandidates moved to library from compiler.
  • loadLibPattern introduced.

@yglukhov yglukhov force-pushed the ssl-init-fix branch 8 times, most recently from 35b1743 to a922b30 Compare November 30, 2016 14:50
@yglukhov
Copy link
Member Author

Ok, that seems to be it. Tested on Linux (both old openssl and new), Windows (old openssl), MacOS (old openssl), Android and iOS (with dynlibOverride + old openssl). This solution is not the cleanest one but should do for now. Any ideas on how to make it cleaner in reasonable timeframe appreciated.

@yglukhov yglukhov changed the title [dont merge] Fixed dynlink with OpenSSL >1.1.0. Added loadLibPattern. Fixed dynlink with OpenSSL >1.1.0. Added loadLibPattern. Nov 30, 2016
@dom96 dom96 merged commit 75345ad into nim-lang:devel Nov 30, 2016
@yglukhov yglukhov deleted the ssl-init-fix branch November 30, 2016 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants