Exports TXmlNode and the k TXmlNodeKind field.
#511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterators like ``items`` will assert on bad input, but end user code can't check the type beforehand because the kind field is not exported.
16 tasks
Clyybber
pushed a commit
to Clyybber/Nim
that referenced
this pull request
Sep 16, 2023
511: add a simple tracing framework r=zerbina a=zerbina ## Summary The goal is to provide the base for an event-based tracing framework that can be incrementally improved/expanded upon. In its current form, it's mainly meant for execution-time tracing. While generally tailored towards being used as part of the compiler, it's meant to be general enough to be used for both one-off temporary instrumentation for use during debugging, and for building a persistent, maybe even user-facing, compiler tracing facility. For example, it could be expanded to also support the tracing done by `debugutils`. This commit only adds the framework and a JSON serializer - both are not used anywhere in the compiler yet. ## Details The `tracer` module implements the data types and routines that make up the framework. The `trace_dump` module implements a serializer to the "Chrome Trace Event" JSON Object format, which was chosen due to it being simple-yet-powerful, with multiple visualizers already existing for it. Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterators like
itemswill assert on bad input, but end user codecan't check the type beforehand because the kind field is not exported.