Don't run "kde-open" and "gnome-open" under Unix #6426
Conversation
All these utilities where replaced by xdg-open from package xdg-utils in Linux and the BSDs.
|
However I did not remove the last method to use the BROWSER env variable but I think (based on the availability of |
|
Also since shellExecuteA was removed from winlean, couldn't this code be simplified even further? |
|
Testing on a Linux machine is not good enough. Also: What about older Linux/disto versions? |
|
Gnome-open was faced-out in circa 2012. CentOS 6.9 has xdg-utils it in its repo. Kde-open must be a relic from KDE-3 times cause it doesn't exist in KDE4. |
shellExecuteA was removed from module winlean
| discard shellExecuteA(0'i32, "open", url, nil, nil, SW_SHOWNORMAL) | ||
| var o = newWideCString("open") | ||
| var u = newWideCString(url) | ||
| discard shellExecuteW(0'i32, o, u, nil, nil, SW_SHOWNORMAL) |
There was a problem hiding this comment.
this seems unrelated to xdg-open? Is this because the uri should always be utf-8?
There was a problem hiding this comment.
Yes unrelated. I removed the condition because shellExecuteA is removed thus dead code.
All these utilities where replaced by xdg-open from package xdg-utils in Linux and the BSDs.
Checked: CentOS, Solaris, NetBSD, OpenBSD, FreeBSD' they all have it in their repos.
Testing done: Run it at a Linux system works.