fix allocator corruption for large sizes #7338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pure gold. :-) Can we have a test case for this too? |
|
You cannot coalesce huge blocks, they are returned back to the OS immediately and must not be merged into larger blocks. |
|
It's not coalescing HugeChunk's, just large BigChunk's, but being careful to split them if they exceed MaxBigChunkSize. |
|
Ok, my bad. |
|
Unrelated test case failure. Ready to merge? Sure it's correct now? ;-) |
|
Yes, please merge. There may be room for improvement with the coalescing, but at least I think it won't crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents fl from overflowing either from coalescing or just being in the largest bin.